[webkit-reviews] review granted: [Bug 233720] Fix GCC warning about memcpy into a StructureID* buffer : [Attachment 445606] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 233720: Fix GCC warning about memcpy into a StructureID* buffer
https://bugs.webkit.org/show_bug.cgi?id=233720

Attachment 445606: Patch

https://bugs.webkit.org/attachment.cgi?id=445606&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 445606
  --> https://bugs.webkit.org/attachment.cgi?id=445606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445606&action=review

> Source/JavaScriptCore/runtime/StructureChain.cpp:52
> +    static_assert(!StructureID().bits(), "Make sure the value we're going to
memcpy below matches the default StructureID");

This part looks good.

> Source/JavaScriptCore/runtime/StructureID.h:55
> +    constexpr uint32_t bits() const { return m_bits; }

Nice.