[webkit-reviews] review granted: [Bug 233688] [selectors] :focus-visible should stop matching after blur : [Attachment 445571] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 233688: [selectors] :focus-visible should stop matching after blur
https://bugs.webkit.org/show_bug.cgi?id=233688

Attachment 445571: Patch

https://bugs.webkit.org/attachment.cgi?id=445571&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 445571
  --> https://bugs.webkit.org/attachment.cgi?id=445571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445571&action=review

> Source/WebCore/dom/Element.cpp:-847
> -    Style::PseudoClassChangeInvalidation styleInvalidation(*this,
CSSSelector::PseudoClassFocusVisible);

I see direct call to setHasFocusVisible in EventHandler::internalKeyEvent().
Would that miss invalidation now?

Does that case have a test?