[webkit-reviews] review granted: [Bug 233674] [Win] OSAllocator::reserveUncommittedAligned should use aligned allocation : [Attachment 445508] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 05:55:38 PST 2021


Keith Miller <keith_miller at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 233674: [Win] OSAllocator::reserveUncommittedAligned should use aligned
allocation
https://bugs.webkit.org/show_bug.cgi?id=233674

Attachment 445508: Patch

https://bugs.webkit.org/attachment.cgi?id=445508&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 445508
  --> https://bugs.webkit.org/attachment.cgi?id=445508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445508&action=review

> Source/WTF/wtf/win/OSAllocatorWin.cpp:69
>      // FIXME: Is there a way to do this where we can either release the
excess reservation or not reserve it at all?

Nit: I'd remove this FIXME at this point.


More information about the webkit-reviews mailing list