[webkit-reviews] review granted: [Bug 233694] [GTK][a11y] Add implementation of table and table cell interfaces when building with ATSPI : [Attachment 445554] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 233694: [GTK][a11y] Add implementation of table and table cell interfaces
when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=233694

Attachment 445554: Patch

https://bugs.webkit.org/attachment.cgi?id=445554&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 445554
  --> https://bugs.webkit.org/attachment.cgi?id=445554
Patch

Other than changing a few pointer literals to “nulptr” before landing, patch
LGTM.


View in context: https://bugs.webkit.org/attachment.cgi?id=445554&action=review

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:106
9
> +	   return JSStringCreateWithCharacters(0, 0);

While changing this you could replace the first zero with nullptr:

    return JSStringCreateWithCharacters(nullptr, 0);

=]

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:107
8
> +	   return JSStringCreateWithCharacters(0, 0);

Same here: s/0/nullptr

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:109
2
> +	   return JSStringCreateWithCharacters(0, 0);

...and here...

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:110
1
> +	   return JSStringCreateWithCharacters(0, 0);

...one more...

>
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:114
6
> +	   return JSStringCreateWithCharacters(0, 0);

...and another...

(okay, I will stop commenting now on each of those)