[webkit-reviews] review granted: [Bug 233541] [GStreamer] requestVideoFrameCallback support : [Attachment 445418] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 233541: [GStreamer] requestVideoFrameCallback support
https://bugs.webkit.org/show_bug.cgi?id=233541

Attachment 445418: Patch

https://bugs.webkit.org/attachment.cgi?id=445418&action=review




--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 445418
  --> https://bugs.webkit.org/attachment.cgi?id=445418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445418&action=review

There are a couple style issues from the bot as well.

>
Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:122
> +    auto* elementNameForSinkPad = gst_element_get_name(element);

You could even inline this call as parameter of add_probe and save a var.

>
Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:131
> +    auto* elementNameForSrcPad = gst_element_get_name(element);

ditto.