[webkit-reviews] review granted: [Bug 233495] [MSE][WPE] Parameterize maximum buffer size using the MSE_MAX_BUFFER_SIZE env var : [Attachment 445411] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 01:08:44 PST 2021


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 233495: [MSE][WPE] Parameterize maximum buffer size using the
MSE_MAX_BUFFER_SIZE env var
https://bugs.webkit.org/show_bug.cgi?id=233495

Attachment 445411: Patch

https://bugs.webkit.org/attachment.cgi?id=445411&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 445411
  --> https://bugs.webkit.org/attachment.cgi?id=445411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445411&action=review

> Source/WebCore/ChangeLog:24
> +	   * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
Read the MSE_MAX_BUFFER_SIZE environment variable and compute the maximum
buffer size if the size is specified in the variable for all the track types
present in the SourceBufferPrivate. Otherwise, use the default size.

This line is too long.

>
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
:285
> +static void maximumBufferSizeDefaults(size_t& maxBufferSizeVideo, size_t&
maxBufferSizeAudio, size_t& maxBufferSizeText)

If this function is going to operate on statics, I don't think you need the
parameters, just use the statics.

Besides, I think considering this function is only called inside de std::once
call, you could just inline the code there. You would even save a #ifdef.


More information about the webkit-reviews mailing list