[webkit-reviews] review denied: [Bug 229668] [GPU Process](REGRESSION): A detached canvas leaks all the images it draws : [Attachment 436932] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 229668: [GPU Process](REGRESSION): A detached canvas leaks all the images
it draws
https://bugs.webkit.org/show_bug.cgi?id=229668

Attachment 436932: Patch

https://bugs.webkit.org/attachment.cgi?id=436932&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 436932
  --> https://bugs.webkit.org/attachment.cgi?id=436932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436932&action=review

> Source/WebCore/dom/Document.cpp:8942
> +	   if (canvas->isInTreeScope() || (canvas->renderingContext() &&
canvas->renderingContext()->is2d()))
> +	       canvas->prepareForDisplay();

We instead always call preprareForDisplay() but inside the implementation of
that function do the isInTreeScope() check when appropriate.