[webkit-reviews] review denied: [Bug 229690] [git-webkit] Relocate contributors.json : [Attachment 436901] Part 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 12:23:21 PDT 2021

Aakash Jain <aakash_jain at apple.com> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 229690: [git-webkit] Relocate contributors.json

Attachment 436901: Part 1


--- Comment #17 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 436901
  --> https://bugs.webkit.org/attachment.cgi?id=436901
Part 1

View in context: https://bugs.webkit.org/attachment.cgi?id=436901&action=review

> ChangeLog:9
> +	   * metadata/contributors.json: Copied from
Tools/Scripts/webkitpy/common/config/contributors.json, made into list.

As I mentioned on slack, I don't think this is a good idea to modify the file
and move it in single commit. As a reviewer, it's extremely hard for me to
verify whether there were any mistakes while copying and editing this large

There should be one commit which just move/copy the file without any changes in
contributors.json at all (and required changes in other files), so that there
isn't need to review the contents of contributors.json. There should be
separate commit to change the contents of contributors.json

More information about the webkit-reviews mailing list