[webkit-reviews] review granted: [Bug 229714] REGRESSION (r281771): ASSERTION FAILED: !m_deletionHasBegun under WebCore::Permissions::~Permissions() : [Attachment 436917] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 229714: REGRESSION (r281771): ASSERTION FAILED: !m_deletionHasBegun under
WebCore::Permissions::~Permissions()
https://bugs.webkit.org/show_bug.cgi?id=229714

Attachment 436917: Patch

https://bugs.webkit.org/attachment.cgi?id=436917&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436917
  --> https://bugs.webkit.org/attachment.cgi?id=436917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436917&action=review

r=me with nit.

> Source/WebCore/Modules/permissions/PermissionController.h:53
>      PermissionState query(ClientOrigin&&, PermissionDescriptor&&) final {
return PermissionState::Denied; }

We should make the constructor private:
DummyPermissionController() = default;