[webkit-reviews] review denied: [Bug 229705] Add support for CSSKeywordValue in CSS Typed OM : [Attachment 436869] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 229705: Add support for CSSKeywordValue in CSS Typed OM
https://bugs.webkit.org/show_bug.cgi?id=229705

Attachment 436869: Patch

https://bugs.webkit.org/attachment.cgi?id=436869&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 436869
  --> https://bugs.webkit.org/attachment.cgi?id=436869
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436869&action=review

This is a wonderful patch.

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:2
> + * Copyright (C) 2019 Apple Inc. All rights reserved.

2021

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:44
> +    if (value.isNull() || value.isEmpty())

value.isEmpty returns true if value is null, so only one check is needed.

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:52
> +    if (value.isNull() || value.isEmpty())

ditto

> Source/WebCore/css/typedom/CSSKeywordValue.h:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2021

> Source/WebCore/css/typedom/CSSKeywordValue.h:30
> +#include "CSSKeywordValue.h"

This shouldn't include itself.

> Source/WebCore/css/typedom/CSSKeywordValue.h:32
> +#include <wtf/RefCounted.h>

This doesn't look needed.

> Source/WebCore/css/typedom/CSSKeywordValue.h:44
> +    String& value() { return m_value; }

const String& value() const

> Source/WebCore/css/typedom/CSSKeywordValue.idl:2
> +* Copyright (C) 2018 Apple Inc.  All rights reserved.

2021