[webkit-reviews] review granted: [Bug 229721] Loads after session restore marked app initiated in Safari : [Attachment 436915] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 229721: Loads after session restore marked app initiated in Safari
https://bugs.webkit.org/show_bug.cgi?id=229721

Attachment 436915: Patch

https://bugs.webkit.org/attachment.cgi?id=436915&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 436915
  --> https://bugs.webkit.org/attachment.cgi?id=436915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436915&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.h:1592
> +    void goToBackForwardItem(uint64_t navigationID, const
WebCore::BackForwardItemIdentifier&, WebCore::FrameLoadType,
WebCore::ShouldTreatAsContinuingLoad, std::optional<WebsitePoliciesData>&&,
bool);

The bool should have a name here, because it's not clear from the context what
it means.