[webkit-reviews] review granted: [Bug 229721] Loads after session restore marked app initiated in Safari : [Attachment 436915] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 11:21:09 PDT 2021

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 229721: Loads after session restore marked app initiated in Safari

Attachment 436915: Patch


--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 436915
  --> https://bugs.webkit.org/attachment.cgi?id=436915

View in context: https://bugs.webkit.org/attachment.cgi?id=436915&action=review


> Source/WebKit/WebProcess/WebPage/WebPage.h:1592
> +    void goToBackForwardItem(uint64_t navigationID, const
WebCore::BackForwardItemIdentifier&, WebCore::FrameLoadType,
WebCore::ShouldTreatAsContinuingLoad, std::optional<WebsitePoliciesData>&&,

The bool should have a name here, because it's not clear from the context what
it means.

More information about the webkit-reviews mailing list