[webkit-reviews] review granted: [Bug 229643] CSSFontFaceSet.clear() should not clear CSS-connected members : [Attachment 436710] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 229643: CSSFontFaceSet.clear() should not clear CSS-connected members
https://bugs.webkit.org/show_bug.cgi?id=229643

Attachment 436710: Patch

https://bugs.webkit.org/attachment.cgi?id=436710&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 436710
  --> https://bugs.webkit.org/attachment.cgi?id=436710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436710&action=review

> Source/WebCore/css/FontFaceSet.cpp:137
> +	   m_backing->remove(m_backing.get()[facesPartitionIndex]);

Is this high-performance enough? Might be worth thinking that through.