[webkit-reviews] review granted: [Bug 229651] [JSC] Implement Temporal.Calendar : [Attachment 436799] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 229651: [JSC] Implement Temporal.Calendar
https://bugs.webkit.org/show_bug.cgi?id=229651

Attachment 436799: Patch

https://bugs.webkit.org/attachment.cgi?id=436799&action=review




--- Comment #8 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 436799
  --> https://bugs.webkit.org/attachment.cgi?id=436799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436799&action=review

Looks good, given Philip's comments and the resolution of the Slack thread
about implementation-definedness.

> Source/WTF/ChangeLog:11
> +	   * wtf/text/StringImpl.cpp:
> +	   (WTF::StringImpl::createStaticStringImpl):
> +	   * wtf/text/StringImpl.h:
> +	   (WTF::StringImpl::createStaticStringImpl):

I think this deserves a brief explanation. :)

> JSTests/stress/temporal-calendar.js:80
> +	   password: 'hunter2', // Note: Don't really store passwords like that

��