[webkit-reviews] review granted: [Bug 228331] Implement self.structuredClone() : [Attachment 436809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 15:59:54 PDT 2021

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228331: Implement self.structuredClone()

Attachment 436809: Patch


--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 436809
  --> https://bugs.webkit.org/attachment.cgi?id=436809

View in context: https://bugs.webkit.org/attachment.cgi?id=436809&action=review

> Source/WebCore/page/WindowOrWorkerGlobalScope.cpp:51
> +    auto messageData = SerializedScriptValue::create(globalObject, value,
WTFMove(options.transfer), ports, SerializationContext::WindowPostMessage);

It's very unfortunate that we have to serialize to a string just to make the
structured clone.
Have we checked the perf of our implementation with other browsers?
We should make sure our implementation isn't orders of magnitude slower than
other browser's.

More information about the webkit-reviews mailing list