[webkit-reviews] review granted: [Bug 229646] Migrate PrivateClickMeasurements from ResourceLoadStatistics database to new database : [Attachment 436814] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229646: Migrate PrivateClickMeasurements from ResourceLoadStatistics
database to new database
https://bugs.webkit.org/show_bug.cgi?id=229646

Attachment 436814: Patch

https://bugs.webkit.org/attachment.cgi?id=436814&action=review




--- Comment #5 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 436814
  --> https://bugs.webkit.org/attachment.cgi?id=436814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436814&action=review

r=me

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:2
61
> +    mutable std::unique_ptr<WebCore::SQLiteStatement>
m_checkIfTableExistsStatement;

I don't think this needs to be mutable.

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDat
abase.h:92
> +    mutable Statement m_insertObservedDomainStatement;

Do these all need to be mutable? I don't think most are used in const
functions.