[webkit-reviews] review granted: [Bug 229339] Add stubs for Permissions API : [Attachment 436784] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 229339: Add stubs for Permissions API
https://bugs.webkit.org/show_bug.cgi?id=229339

Attachment 436784: Patch

https://bugs.webkit.org/attachment.cgi?id=436784&action=review




--- Comment #40 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436784
  --> https://bugs.webkit.org/attachment.cgi?id=436784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436784&action=review

r=me

> Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp:65
> +	   auto permissionEntries = m_cachedPermissionEntries.get(origin);

Please avoid double-hash table look-up with contains and then get(). (you can
use find()).