[webkit-reviews] review granted: [Bug 228316] Implement self.reportError() : [Attachment 436682] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228316: Implement self.reportError()
https://bugs.webkit.org/show_bug.cgi?id=228316

Attachment 436682: Patch

https://bugs.webkit.org/attachment.cgi?id=436682&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 436682
  --> https://bugs.webkit.org/attachment.cgi?id=436682
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436682&action=review

> Source/WebCore/page/WindowOrWorkerGlobalScope.idl:71
> +    [CallWith=GlobalObject] undefined reportError(any error);

Please move this to below crossOriginIsolated; to match it's location in the
spec (I try to keep these as close to the spec IDL as I can).

> Source/WebCore/workers/WorkerGlobalScope.cpp:551
> +void WorkerGlobalScope::reportError(JSC::JSGlobalObject& globalObject,
JSC::JSValue error)

Kind of a bummer to have to repeat this.