[webkit-reviews] review granted: [Bug 229636] MessageArgumentDescriptions.cpp generator incorrectly strips std::optional<> from argument types : [Attachment 436697] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 17:43:34 PDT 2021


Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 229636: MessageArgumentDescriptions.cpp generator incorrectly strips
std::optional<> from argument types
https://bugs.webkit.org/show_bug.cgi?id=229636

Attachment 436697: Patch

https://bugs.webkit.org/attachment.cgi?id=436697&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 436697
  --> https://bugs.webkit.org/attachment.cgi?id=436697
Patch

Did I break this when moving from WTF::Optional to std::optional? If so, I
wonder how because they are both the same length!


More information about the webkit-reviews mailing list