[webkit-reviews] review granted: [Bug 229620] [GTK] Simplify run-gtk-tests handling of the a11y service : [Attachment 436653] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 12:39:13 PDT 2021

Michael Catanzaro <mcatanzaro at gnome.org> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 229620: [GTK] Simplify run-gtk-tests handling of the a11y service

Attachment 436653: Patch


--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 436653
  --> https://bugs.webkit.org/attachment.cgi?id=436653

View in context: https://bugs.webkit.org/attachment.cgi?id=436653&action=review

> Tools/Scripts/run-gtk-tests:56
> +	       sys.stderr.write("Failed to talk to the accessibility service

Let's add a colon: "Failed to talk to the accessibility service: {}\n"

Also, can you check to ensure passing the error directly works? It will really
print a nice error string and not some object ID? There is no e.message
property that needs to be used instead?

More information about the webkit-reviews mailing list