[webkit-reviews] review granted: [Bug 229542] [CSS Cascade Layers] Initial support : [Attachment 436491] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 10:17:13 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 229542: [CSS Cascade Layers] Initial support
https://bugs.webkit.org/show_bug.cgi?id=229542

Attachment 436491: patch

https://bugs.webkit.org/attachment.cgi?id=436491&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 436491
  --> https://bugs.webkit.org/attachment.cgi?id=436491
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436491&action=review

> Source/WebCore/css/StyleRule.h:265
> +    Variant<CascadeLayerName, Vector<CascadeLayerName>> m_nameVariant;

Is this preferable to just always using a Vector<>? Or is a name list with one
item different from a simple name?

> Source/WebCore/css/StyleRuleType.h:40
>      Namespace = 10,

What happened to 9? Why do we number these from here on?

> Source/WebCore/css/parser/CSSAtRuleID.h:51
> +    CSSAtRuleLayer = 13,

Not sure why we need exploit values here?

> Source/WebCore/style/RuleSet.cpp:510
> +	       // FIXME: This is not correct when adding a sublayer to an
already registered layer after it has gained siblings.

Reference a bug url?

> Source/WebCore/style/RuleSet.h:196
> +    // FIXME: These should be in stack.

in a stack? on the stack?


More information about the webkit-reviews mailing list