[webkit-reviews] review denied: [Bug 229607] [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies : [Attachment 436620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 27 06:53:14 PDT 2021

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Diego Pino
<dpino at igalia.com>'s request for review:
Bug 229607: [GTK][WPE] Add ICU 63.1 to JHBuild minimal dependencies

Attachment 436620: Patch


--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 436620
  --> https://bugs.webkit.org/attachment.cgi?id=436620

View in context: https://bugs.webkit.org/attachment.cgi?id=436620&action=review

> Tools/jhbuild/jhbuild-minimal.modules:96
> +  <autotools id="icu"
> +		autogen-sh="./source/configure"
> +		autogenargs="--disable-samples --enable-weak-threads">
> +    <branch module="icu4c-63_1-src.tgz" version="63.1" checkoutdir="icu"
> +	       repo="webkitgtk-jhbuild-mirror"
> +	      
> +	 <patch file="icudata-stdlibs.patch" strip="1"/>
> +    </branch>
> +  </autotools>

The idea of the minimal jhbuild moduleset is to use the version of the system
is if is new enough.
To achieve that we declare how to build the minimum version needed of the
library, and in this case the minimum version is ICU 61 and not 63.
Also we need a <pkg-config> entry to tell jhbuild to look for the .pc file and
use the system version if is new enough.
Please consider this version of patch: http://sprunge.us/iyZbDk (it works for
me to fix the build)

More information about the webkit-reviews mailing list