[webkit-reviews] review granted: [Bug 223317] webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html fails : [Attachment 436546] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 223317: webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html
fails
https://bugs.webkit.org/show_bug.cgi?id=223317

Attachment 436546: Patch

https://bugs.webkit.org/attachment.cgi?id=436546&action=review




--- Comment #8 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 436546
  --> https://bugs.webkit.org/attachment.cgi?id=436546
Patch

Great work Kimmo diagnosing and fixing this. It sounds like you've carefully
analyzed what was going wrong here, so looks good to me. It would be good if
Kyle could look at this too before landing.

(As an aside, I wish we'd finished the upstreaming process so that large
changes like this didn't make WebKit's and ANGLE's code diverge further.)

r+