[webkit-reviews] review granted: [Bug 229089] [git-webkit] Add pull-request command : [Attachment 436288] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 229089: [git-webkit] Add pull-request command
https://bugs.webkit.org/show_bug.cgi?id=229089

Attachment 436288: Patch

https://bugs.webkit.org/attachment.cgi?id=436288&action=review




--- Comment #37 from dewei_zhu at apple.com ---
Comment on attachment 436288
  --> https://bugs.webkit.org/attachment.cgi?id=436288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436288&action=review

r=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:203
> +		   states = params.get('state', [])

params can be `None` right? Do we need `states = (params or {}).get('state',
[])` ?

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:207
> +		   at = params.get('at')

Ditto.