[webkit-reviews] review granted: [Bug 217365] [Payment Request] Calling PaymentRequest's show() should consume user activation : [Attachment 436443] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Marcos Caceres
<marcos at marcosc.com>'s request for review:
Bug 217365: [Payment Request] Calling PaymentRequest's show() should consume
user activation
https://bugs.webkit.org/show_bug.cgi?id=217365

Attachment 436443: Patch

https://bugs.webkit.org/attachment.cgi?id=436443&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 436443
  --> https://bugs.webkit.org/attachment.cgi?id=436443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436443&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:375
> +    if (window && !window->consumeTransientActivation()) {

Should it be:
if (!window || !window->consumeTransientActivation()) {
}

>
LayoutTests/imported/w3c/web-platform-tests/payment-request/payment-is-showing.
https.html:7
> +<meta name="timeout" content="long" />

I am guessing this is resyncing our copy of WPT tests with upstream.
If so, can you update the change log?