[webkit-reviews] review canceled: [Bug 229461] Fix static analyzer warnings about nullptr derefs in WTF::StringImpl::copyCharacters() and WTF::StringTypeAdapter::writeTo() : [Attachment 436444] Patch v4

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 229461: Fix static analyzer warnings about nullptr derefs in
WTF::StringImpl::copyCharacters() and WTF::StringTypeAdapter::writeTo()
https://bugs.webkit.org/show_bug.cgi?id=229461

Attachment 436444: Patch v4

https://bugs.webkit.org/attachment.cgi?id=436444&action=review




--- Comment #15 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 436444
  --> https://bugs.webkit.org/attachment.cgi?id=436444
Patch v4

Well this is awkward.  Looks like non-Apple compilers think
StringImpl::copyCharacters() is static, but Apple's clang compiler thinks it's
not static.