[webkit-reviews] review granted: [Bug 229456] [iOS] Unable to select files when the accept attribute is set to "*/*" : [Attachment 436422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 25 14:02:56 PDT 2021
Chris Dumez <cdumez at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 229456: [iOS] Unable to select files when the accept attribute is set to
"*/*"
https://bugs.webkit.org/show_bug.cgi?id=229456
Attachment 436422: Patch
https://bugs.webkit.org/attachment.cgi?id=436422&action=review
--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436422
--> https://bugs.webkit.org/attachment.cgi?id=436422
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=436422&action=review
r=me with comment
> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:358
> + if ([mimeType caseInsensitiveCompare:@"*/*"] == NSOrderedSame)
nit: Do we really need a caseInsensitiveCompare for "*/*"?
More information about the webkit-reviews
mailing list