[webkit-reviews] review granted: [Bug 226291] Implement Object.hasOwn : [Attachment 436284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 10:49:08 PDT 2021


Alexey Shvayka <shvaikalesh at gmail.com> has granted Aditi Singh
<asingh at igalia.com>'s request for review:
Bug 226291: Implement Object.hasOwn
https://bugs.webkit.org/show_bug.cgi?id=226291

Attachment 436284: Patch

https://bugs.webkit.org/attachment.cgi?id=436284&action=review




--- Comment #22 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 436284
  --> https://bugs.webkit.org/attachment.cgi?id=436284
Patch

(In reply to Jamie Kyle from comment #19)
> test262 does include tests for the order of `ToObject` and `ToPropertyKey`:

Jamie, thanks for all the work on this proposal, and especially for thorough
test coverage!


Aditi, �� on the first patch, well done!
A bugzilla tip for future: once a patch is reviewed, please edit ChangeLogs
with reviewer's name and upload follow-ups w/o r? flag.


More information about the webkit-reviews mailing list