[webkit-reviews] review denied: [Bug 229466] Update availability macros for APIs available in iOS 14.5 and macOS 11.3 : [Attachment 436326] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229466: Update availability macros for APIs available in iOS 14.5 and macOS
11.3
https://bugs.webkit.org/show_bug.cgi?id=229466

Attachment 436326: Patch

https://bugs.webkit.org/attachment.cgi?id=436326&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436326
  --> https://bugs.webkit.org/attachment.cgi?id=436326
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436326&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533
>> + at property (nonatomic, nullable, copy) id interactionState
WK_API_AVAILABLE(macos(11.3), ios(14.5));
> 
> How did you determine those? For example, this particular API was added in
rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure
about the other APIs).

This was not in iOS 11.3:
https://trac.webkit.org/browser/webkit/branches/safari-611.1.21.0-branch/Source
/WebKit/UIProcess/API/Cocoa/WKWebView.h

Other APIs updated in this patch are potentially incorrect too given they are
based on the same diff.