[webkit-reviews] review granted: [Bug 117493] Caret should respect text background color : [Attachment 436267] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 12:50:08 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Joone Hur <joone at webkit.org>'s
request for review:
Bug 117493: Caret should respect text background color
https://bugs.webkit.org/show_bug.cgi?id=117493

Attachment 436267: Patch

https://bugs.webkit.org/attachment.cgi?id=436267&action=review




--- Comment #36 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 436267
  --> https://bugs.webkit.org/attachment.cgi?id=436267
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436267&action=review

> Source/WebCore/editing/FrameSelection.cpp:1793
> +    auto* parentElement = node ? node->parentElement() : nullptr;

Please use RefPtr


More information about the webkit-reviews mailing list