[webkit-reviews] review denied: [Bug 229451] Add new experimental feature flag for sanitizing links : [Attachment 436313] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 12:36:13 PDT 2021

Kate Cheney <katherine_cheney at apple.com> has denied Risul Islam
<risul_islam at apple.com>'s request for review:
Bug 229451: Add new experimental feature flag for sanitizing links

Attachment 436313: Patch


--- Comment #3 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 436313
  --> https://bugs.webkit.org/attachment.cgi?id=436313

View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:643
> +  humanReadableName: "Link Sanitizer enabled"

I think this should just be "Link sanitizer"...

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644
> +  humanReadableDescription: "Sanitize the links"

...then this should be "Enable link sanitizer" to better align with other
examples in this file.

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647
> +	 default: true

r- because this feature should be off by default, so default values should be

More information about the webkit-reviews mailing list