[webkit-reviews] review granted: [Bug 229453] [Monterey] LayoutTest media/element-containing-pip-video-going-into-fullscreen.html is flaky timeout/crash : [Attachment 436306] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 229453: [Monterey] LayoutTest
media/element-containing-pip-video-going-into-fullscreen.html is flaky
timeout/crash
https://bugs.webkit.org/show_bug.cgi?id=229453

Attachment 436306: Patch

https://bugs.webkit.org/attachment.cgi?id=436306&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 436306
  --> https://bugs.webkit.org/attachment.cgi?id=436306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436306&action=review

> Source/WebKit/ChangeLog:16
> +	   This change fixes an assertion failure in
`enterVideoFullscreenForVideoElement()`.

This requires the reader to look at the code before and after the change.
Instead I think it would be better to say something like "Return immediately if
the element is not in fullscreen to avoid an assertion later in
`enterVideoFullscreenForVideoElement`".