[webkit-reviews] review granted: [Bug 229381] Add onsecuritypolicyviolation on GlobalEventHandlers : [Attachment 436281] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Sonia Singla
<soniasingla.1812 at gmail.com>'s request for review:
Bug 229381: Add onsecuritypolicyviolation on  GlobalEventHandlers
https://bugs.webkit.org/show_bug.cgi?id=229381

Attachment 436281: Patch

https://bugs.webkit.org/attachment.cgi?id=436281&action=review




--- Comment #13 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 436281
  --> https://bugs.webkit.org/attachment.cgi?id=436281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436281&action=review

LGTM, with the "PASSS" typo fixed.

>
LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.
txt:5084
> +PASSS SVGElement interface: attribute onsecuritypolicyviolation

"PASS" without extra S. I guess the EWS tests are not failing since we have
other idlharness.https-expected.txt for mac, but that's going to fail once we
land it.