[webkit-reviews] review granted: [Bug 229426] De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint : [Attachment 436240] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 229426: De-flake media painting tests by delaying readyState >=
HAVE_CURRENT_DATA until element is able to paint
https://bugs.webkit.org/show_bug.cgi?id=229426

Attachment 436240: Patch

https://bugs.webkit.org/attachment.cgi?id=436240&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 436240
  --> https://bugs.webkit.org/attachment.cgi?id=436240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436240&action=review

> Source/WebCore/ChangeLog:27
> +	   a RGB image.

s/a/an/

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:569
> +		   // progress to LikelyToKeepUp. Set the readyState to 
HAVE_ENOUGH_DATA, on the

Nit: extra space between "to" and "HAVE_ENOUGH_DATA"

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:591
> +	       // Do not allow us to progress  beyond HaveMetadata until the
layer is ready for display

Nit: extra space between "progress" and "beyond"