[webkit-reviews] review granted: [Bug 229303] Setting window.location.href to an invalid URL should throw a TypeError : [Attachment 436223] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229303: Setting window.location.href to an invalid URL should throw a
TypeError
https://bugs.webkit.org/show_bug.cgi?id=229303

Attachment 436223: Patch

https://bugs.webkit.org/attachment.cgi?id=436223&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436223
  --> https://bugs.webkit.org/attachment.cgi?id=436223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436223&action=review

> Source/WebCore/ChangeLog:8
> +	   This matches Firefox and the specification

Looks like Chrome does throw an exception, right? Just not the right exception
type?

If so, the compatibility risk does seem low.

> Source/WebCore/page/Location.cpp:281
> +	   return Exception { TypeError, "Invalid URL" };

nit: "Invalid URL"_s