[webkit-reviews] review granted: [Bug 229343] REGRESSION(r281305) [GStreamer] fast/mediastream/getDisplayMedia-frame-rate.html timeouts : [Attachment 436199] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 229343: REGRESSION(r281305) [GStreamer]
fast/mediastream/getDisplayMedia-frame-rate.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=229343

Attachment 436199: Patch

https://bugs.webkit.org/attachment.cgi?id=436199&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 436199
  --> https://bugs.webkit.org/attachment.cgi?id=436199
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436199&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.
cpp:76
> +    m_source->removeVideoSampleObserver(*this);

Might be good  to stop observing when stopping as well.
I would do like RealtimeVideoSource.