[webkit-reviews] review granted: [Bug 214795] [JSC] Add Intl Enumeration APIs : [Attachment 436147] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 214795: [JSC] Add Intl Enumeration APIs
https://bugs.webkit.org/show_bug.cgi?id=214795

Attachment 436147: Patch

https://bugs.webkit.org/attachment.cgi?id=436147&action=review




--- Comment #18 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 436147
  --> https://bugs.webkit.org/attachment.cgi?id=436147
Patch

r=me

(In reply to Yusuke Suzuki from comment #15)
> >> JSTests/stress/intl-enumeration.js:19
> >> +shouldBe(JSON.stringify(calendars),
`["buddhist","chinese","coptic","dangi","ethioaa","ethiopic","gregory","hebrew"
,"indian","islamic","islamic-civil","islamic-rgsa","islamic-tbla","islamic-umal
qura","iso8601","japanese","persian","roc"]`);
> > 
> > Are we sure that all current ICU versions will have these exact values for
each enumeration?
> 
> Not sure, but at least, it passed EWS. We should just modify when we found
> another things since it is not possible to collect all candidates of all ICU
> versions.

Fair enough; I guess I was thinking like "`calendars` contains _at least_ these
values", etc.