[webkit-reviews] review granted: [Bug 214795] [JSC] Add Intl Enumeration APIs : [Attachment 436147] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 10:32:21 PDT 2021

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 214795: [JSC] Add Intl Enumeration APIs

Attachment 436147: Patch


--- Comment #18 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 436147
  --> https://bugs.webkit.org/attachment.cgi?id=436147


(In reply to Yusuke Suzuki from comment #15)
> >> JSTests/stress/intl-enumeration.js:19
> >> +shouldBe(JSON.stringify(calendars),
> > 
> > Are we sure that all current ICU versions will have these exact values for
each enumeration?
> Not sure, but at least, it passed EWS. We should just modify when we found
> another things since it is not possible to collect all candidates of all ICU
> versions.

Fair enough; I guess I was thinking like "`calendars` contains _at least_ these
values", etc.

More information about the webkit-reviews mailing list