[webkit-reviews] review granted: [Bug 165279] Implement inert attribute (affects keyboard, events, and accessibility) : [Attachment 436200] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 09:15:13 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 165279: Implement inert attribute (affects keyboard, events, and
accessibility)
https://bugs.webkit.org/show_bug.cgi?id=165279

Attachment 436200: Patch

https://bugs.webkit.org/attachment.cgi?id=436200&action=review




--- Comment #25 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 436200
  --> https://bugs.webkit.org/attachment.cgi?id=436200
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436200&action=review

r=me

> Source/WebCore/dom/Node.cpp:2636
> +	   auto* element = is<Element>(this) ? downcast<Element>(this) :
parentElement();

is<Element>(*this) to avoid an unnecessary null-check.


More information about the webkit-reviews mailing list