[webkit-reviews] review granted: [Bug 229368] Use an ObjectIdentifier<> type for policy listener IDs : [Attachment 436079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 07:52:39 PDT 2021


Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 229368: Use an ObjectIdentifier<> type for policy listener IDs
https://bugs.webkit.org/show_bug.cgi?id=229368

Attachment 436079: Patch

https://bugs.webkit.org/attachment.cgi?id=436079&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 436079
  --> https://bugs.webkit.org/attachment.cgi?id=436079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436079&action=review

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:216
> +static uint64_t generateListenerID()

Maybe rename this to generateFormListenerID() if that's the only thing it's
used for now.


More information about the webkit-reviews mailing list