[webkit-reviews] review granted: [Bug 229356] Use the strongly typed PageGroupIdentifier in place of uint64_t : [Attachment 436041] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 20 16:34:45 PDT 2021
Alex Christensen <achristensen at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 229356: Use the strongly typed PageGroupIdentifier in place of uint64_t
https://bugs.webkit.org/show_bug.cgi?id=229356
Attachment 436041: Patch
https://bugs.webkit.org/attachment.cgi?id=436041&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 436041
--> https://bugs.webkit.org/attachment.cgi?id=436041
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=436041&action=review
> Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.h:48
> + // Namespace IDs for local storage namespaces are equivalent to web page
group IDs.
I would update this to "currently equivalent" because I think we intend to
change this once we completely remove WebPageGroup/WebPageGroupProxy.
> Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:56
> + // Namespace IDs for local storage namespaces are equivalent to web page
group IDs.
ditto
More information about the webkit-reviews
mailing list