[webkit-reviews] review granted: [Bug 227832] [JSC] Intl.DisplayNames v2 : [Attachment 435951] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 227832: [JSC] Intl.DisplayNames v2
https://bugs.webkit.org/show_bug.cgi?id=227832

Attachment 435951: Patch

https://bugs.webkit.org/attachment.cgi?id=435951&action=review




--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 435951
  --> https://bugs.webkit.org/attachment.cgi?id=435951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435951&action=review

r=me with comments

> Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:210
> +	   // If code does not matches the unicode_language_id production,
throw a RangeError exception
> +	   if (!isUnicodeLanguageId(code)) {
> +	       throwRangeError(globalObject, scope, "argument is not a language
id"_s);

Hmm, I feel like this comment doesn't add any information. (Ditto for the
region and script ones.)

> Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:295
> +	   // Convert code to legacy names since ICU requires legacy names.

Ooh, this could use the helper function I suggested in the Locale Info patch
too.