[webkit-reviews] review requested: [Bug 229348] Improve diagnostics for missing files in DerivedSources.make : [Attachment 436022] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 13:31:23 PDT 2021

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 229348: Improve diagnostics for missing files in DerivedSources.make

Attachment 436022: proposed patch


--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Created attachment 436022

  --> https://bugs.webkit.org/attachment.cgi?id=436022&action=review

proposed patch

In testing, this patch appears to resolve the build failures instead of
providing diagnostics, which is not quite satisfactory, and the theory may be

I don't see how to further diagnose the issue, and in any case, we'll have
better diagnostics if the build fails again in the future, so it's an
improvement either way.

More information about the webkit-reviews mailing list