[webkit-reviews] review granted: [Bug 229332] Add some offlineasm enhancements. : [Attachment 435966] proposed patch.

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 229332: Add some offlineasm enhancements.
https://bugs.webkit.org/show_bug.cgi?id=229332

Attachment 435966: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=435966&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 435966
  --> https://bugs.webkit.org/attachment.cgi?id=435966
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=435966&action=review

r=me with nits

> Source/JavaScriptCore/ChangeLog:10
> +	      file from /usr/local/include/WebKitAdditions/ first.  If the
specified file is

Nit: This is technically <build-products>/usr/local/include/WebKitAdditions.

> Source/JavaScriptCore/offlineasm/parser.rb:266
> +	   @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR'];

Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake
doesn't set that environment variable.