[webkit-reviews] review granted: [Bug 229323] Make UIEventAttribution tests less platform dependent : [Attachment 435943] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229323: Make UIEventAttribution tests less platform dependent
https://bugs.webkit.org/show_bug.cgi?id=229323

Attachment 435943: Patch

https://bugs.webkit.org/attachment.cgi?id=435943&action=review




--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 435943
  --> https://bugs.webkit.org/attachment.cgi?id=435943
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435943&action=review

r=me as long as the broken iOS test is fixed.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:58
> +- (void)_addEventAttributionWithSourceID:(uint8_t)sourceID
destinationURL:(NSURL *)destination sourceDescription:(NSString
*)sourceDescription purchaser:(NSString *)purchaser reportEndpoint:(NSURL
*)reportEndpoint nonce:(NSString *)nonce

Should we call the nonce parameter optionalNonce?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:265
> +    [webView _addEventAttributionWithSourceID:42 destinationURL:exampleURL()
sourceDescription:@"test source description" purchaser:@"test purchaser"
reportEndpoint:serverURL nonce:@"ABCDEFabcdef0123456789"];

Where did 42 come from? Did it come from MockEventAttribution before?