[webkit-reviews] review granted: [Bug 229319] [ews-build.webkit.org] Add unit test with the expected build steps for each queue : [Attachment 435940] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 20 05:18:51 PDT 2021

Aakash Jain <aakash_jain at apple.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 229319: [ews-build.webkit.org] Add unit test with the expected build steps
for each queue

Attachment 435940: Patch


--- Comment #5 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 435940
  --> https://bugs.webkit.org/attachment.cgi?id=435940

View in context: https://bugs.webkit.org/attachment.cgi?id=435940&action=review

> Tools/CISupport/ews-build/factories_unittest.py:32
> +	   "Style-EWS": [

Nit: we prefer using single quotes, but might be ok for now, we can change it
later as well.

> Tools/CISupport/ews-build/factories_unittest.py:572
> +	       self.assertListEqual(self.expected_steps[builder['name']],
buildSteps, msg="Expected results don't match for builder %s" %

Nit: "results" => "steps"

More information about the webkit-reviews mailing list