[webkit-reviews] review granted: [Bug 229072] [MSE][GStreamer] Implement multi-track support : [Attachment 435866] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 229072: [MSE][GStreamer] Implement multi-track support
https://bugs.webkit.org/show_bug.cgi?id=229072

Attachment 435866: Patch

https://bugs.webkit.org/attachment.cgi?id=435866&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 435866
  --> https://bugs.webkit.org/attachment.cgi?id=435866
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435866&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:366
> +		   m_done = true;

Nit: TRUE

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:296
> +    GRefPtr<GstCaps> parsedCaps = GRefPtr<GstCaps>(demuxerSrcPadCaps);

Do you need to explicitly call the constructor? It should be called
automatically, right?

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:298
> +    FloatSize presentationSize = FloatSize();

Isn't no parameters default constructor being called here as well?

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:314
> +    return { parsedCaps, streamType, presentationSize };

Please, WTFMove the objects into the tuple.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:489
> +    GST_DEBUG("Notifying SourceBuffer of initialization segement.");

*segment

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:699
> +	   GST_WARNING_OBJECT(pipeline(), "Couldn't find a matching
pre-existing track for pad '%s' with parsed caps %" GST_PTR_FORMAT " on
non-first initialization segment, will be connected to a black hole probe.",
GST_PAD_NAME(demuxerSrcPad), parsedCaps.get());

Huge line :)

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:705
> +void AppendPipeline::linkPadWithTrack(GstPad *demuxerSrcPad, Track &track)

GstPad* demuxerSrcPad, Track& track

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:830
> +const char* AppendPipeline::streamTypeToString(StreamType streamType)

This is breaking the build

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:112
> +    static std::tuple<GRefPtr<GstCaps>, AppendPipeline::StreamType,
FloatSize> parseDemuxerSrcPadCaps(GstCaps* demuxerSrcPadCaps);
> +    Ref<WebCore::TrackPrivateBase> makeWebKitTrack(int trackIndex);

Think if you can remove paremeter names, plz.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:126
> +    std::pair<CreateTrackResult, AppendPipeline::Track*>
tryCreateTrackFromPad(GstPad* demuxerSrcPad, int padIndex);
> +    AppendPipeline::Track* tryMatchPadToExistingTrack(GstPad*
demuxerSrcPad);
> +    void linkPadWithTrack(GstPad* demuxerSrcPad, Track&);

Think if you can remove paremeter names, plz.