[webkit-reviews] review granted: [Bug 229269] Touchbar not showing time scrubbing : [Attachment 435859] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 229269: Touchbar not showing time scrubbing
https://bugs.webkit.org/show_bug.cgi?id=229269

Attachment 435859: Patch

https://bugs.webkit.org/attachment.cgi?id=435859&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 435859
  --> https://bugs.webkit.org/attachment.cgi?id=435859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435859&action=review

> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:93
> ++ (NSSet<NSString *> *)keyPathsForValuesAffectingCanSeek
> +{
> +    return [NSSet setWithObject:@"seekableTimeRanges"];
> +}
> +

Nit: I would put this right above -(BOOL)canSeek, rather than next to
seekableTimeRanges.