[webkit-reviews] review granted: [Bug 229100] Use Vector<SandboxExtension::Handle> instead of SandboxExtension::HandleArray : [Attachment 435520] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 229100: Use Vector<SandboxExtension::Handle> instead of
SandboxExtension::HandleArray
https://bugs.webkit.org/show_bug.cgi?id=229100

Attachment 435520: Patch

https://bugs.webkit.org/attachment.cgi?id=435520&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 435520
  --> https://bugs.webkit.org/attachment.cgi?id=435520
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435520&action=review

r=me

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:428
> +bool SandboxExtension::consumePermanently(const
Vector<SandboxExtension::Handle>& handleArray)

Wouldn't `const Vector<Handle>&` work?

> Source/WebKit/Shared/SandboxExtension.h:127
> +inline auto SandboxExtension::createReadOnlyHandlesForFiles(ASCIILiteral,
const Vector<String>&) -> Vector<Handle> { return { }; }

Do we need the auto return value here? Wouldn't `Vector<Handle>` as return
value work here since we're in the class scope?