[webkit-reviews] review granted: [Bug 229138] Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec : [Attachment 435879] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 229138: Signaling state check when applying a local or remote description
is no longer aligned with the WebRTC spec
https://bugs.webkit.org/show_bug.cgi?id=229138

Attachment 435879: Patch

https://bugs.webkit.org/attachment.cgi?id=435879&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 435879
  --> https://bugs.webkit.org/attachment.cgi?id=435879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435879&action=review

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:278
> +    default:

It might be better to include the other cases here and leave out `default` so
we'll get a compile error if an enum added or removed.

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:310
> +    default:

Ditto