[webkit-reviews] review granted: [Bug 228941] REGRESSION(r280732) [GStreamer] fast/mediastream/getDisplayMedia-max-constraints1.html and other are failing : [Attachment 435857] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 228941: REGRESSION(r280732) [GStreamer]
fast/mediastream/getDisplayMedia-max-constraints1.html and other are failing
https://bugs.webkit.org/show_bug.cgi?id=228941

Attachment 435857: Patch

https://bugs.webkit.org/attachment.cgi?id=435857&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 435857
  --> https://bugs.webkit.org/attachment.cgi?id=435857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435857&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.
h:31
>  class MockRealtimeVideoSourceGStreamer final : public
MockRealtimeVideoSource {

It seems MockRealtimeVideoSourceGStreamer is only used for display. Should its
name be updated? Should it be merged with MockDisplayCaptureSourceGStreamer at
some point?

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.
h:47
> +   
MockDisplayCaptureSourceGStreamer(RefPtr<MockRealtimeVideoSourceGStreamer>&&
source, CaptureDevice::DeviceType type)

Can it be made private? Can we pass a Ref<>&& source.

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.
h:67
> +    RefPtr<MockRealtimeVideoSourceGStreamer> m_source;

Can we make it a Ref<>