[webkit-reviews] review granted: [Bug 229202] [App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated : [Attachment 435767] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 229202: [App Privacy Report] Some HTTP Redirects from non app initiated
requests are marked app initiated
https://bugs.webkit.org/show_bug.cgi?id=229202

Attachment 435767: Patch

https://bugs.webkit.org/attachment.cgi?id=435767&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 435767
  --> https://bugs.webkit.org/attachment.cgi?id=435767
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435767&action=review

R=me

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:617
> +		   nsRequest = mutableRequest.get();

It would be better if we could initialize attribution when we construct the
NSURLRequest from the request above, but this is fine for now.